Stop external-builder envelope 404 after block publication by jimmygchen · Pull Request #9948 · sigp/lighthouse

jimmygchen · 2026-08-31T04:42:43Z

After publishing a Gloas beacon block selected from an external builder, the validator client immediately fetches the payload envelope from its beacon node. That endpoint only serves locally built envelopes, so it returns 404 before the selected builder publishes its envelope. The block still lands, but the validator client reports Error whilst producing block.

The validator client now fetches, signs, and publishes an envelope only when the selected bid has builder_index == BUILDER_INDEX_SELF_BUILD. For an external builder, it stops after publishing the signed beacon block.

…(Gloas builder API 3/5) Third PR of the Gloas builder API stack: - beacon_chain: direct builder bid verification (spawned on the blocking executor), gossip-bid refinements, wei-domain bid selection (`BidCandidate`/`BidSource`), and Gloas block production that assembles local, gossip, and direct-builder candidates - network: process payload-bid and proposer-preference gossip, including the new `PayloadBidError` variants - client: construct the `Builders` service when the Gloas fork is scheduled and wire it into the beacon chain The HTTP API still serves `GET` produceBlockV4 at this point; the `POST` conversion and the `Eth-Builder-Url` round-trip land in the next PR. Change-Id: Ieccaee5db81bf871c19cef1b79fc48283be9dd51

…builder API 4/5) Fourth PR of the Gloas builder API stack (beacon-APIs sigp#630): - convert `/eth/v4/validator/blocks/{slot}` to POST with an optional `BuilderConfig` body (min_bid, builder_boost_factor, direct builders) - add `POST /eth/v1/validator/builder_preferences` for forwarding signed builder preferences - set `Eth-Builder-Url` on produceBlockV4 responses when a direct-builder bid wins, accept it on `POST /eth/v2/beacon/blocks`, and forward the signed block to that builder The validator client still uses the legacy GET methods at this point; it migrates in the final PR of this stack. Change-Id: I0ad30b8f36ad9b588ea1a0398220f92c9597bb95

…API 5/5) Final PR of the Gloas builder API stack: - sign builder request-auth and preferences (REQUEST_AUTH signing domain, web3signer message type) - add the builder configuration store (`builder_definitions.yml`) and book documentation - add the builder-preferences service and switch block production to `POST` produceBlockV4 with a `BuilderConfig` body, threading the `Eth-Builder-Url` header through block publication - remove the now-unused legacy `GET` produceBlockV4 client methods Change-Id: Iaeeaf6205a024e4fb9fd11aae6ac6a75978a8320

Changes: Skip validator payload-envelope handling after external-builder block publication. Cover self-build and external-builder envelope behaviour.

mergify · 2026-09-01T17:28:27Z

This pull request has merge conflicts. Could you please resolve them @jimmygchen? 🙏

shane-moore · 2026-09-02T03:27:37Z

+            publish_envelope =
+                signed_execution_payload_bid.message.builder_index == BUILDER_INDEX_SELF_BUILD;


this reads the bid from this VC's own produce response, before sign_and_publish_block swaps in the block the cluster agreed on. for a DVT store those differ: one validator key is split into shares across N independent VC+BN pairs (SSV operators), sign_block runs consensus across them and usually returns another VC's block, and a threshold have to sign for anything to publish. so when this VC's own bid is external while the agreed block is self-build, the envelope step is skipped here and this VC's share goes missing. the reverse runs it with nothing to reveal.

sign_and_publish_block already holds the signed_block and drops it. suggest returning it (or just its bid) and deriving publish_envelope from that after the call. no-op for a normal store, where the block that comes back is the one that went in.

one thing to leave as-is: the fetch root. keep payload_envelope_block_root as unsigned_block.block_root(), just unconditionally. on the VC that built the agreed block the two roots are equal; on the others the agreed root is not in their own BN's pending_payload_envelopes (local building only, validator/execution_payload_envelopes.rs 404s otherwise), so keying on it would 404 everywhere and the store would never be called. they still need to sign, and anchor discards the fetched envelope on them anyway, so the fetch only has to succeed.

going to think deeper if i can handle this on anchor side, so commenting out the above for now

…(Gloas builder API 3/5) Third PR of the Gloas builder API stack: - beacon_chain: direct builder bid verification (spawned on the blocking executor), gossip-bid refinements, wei-domain bid selection (`BidCandidate`/`BidSource`), and Gloas block production that assembles local, gossip, and direct-builder candidates - network: process payload-bid and proposer-preference gossip, including the new `PayloadBidError` variants - client: construct the `Builders` service when the Gloas fork is scheduled and wire it into the beacon chain The HTTP API still serves `GET` produceBlockV4 at this point; the `POST` conversion and the `Eth-Builder-Url` round-trip land in the next PR. Change-Id: Ieccaee5db81bf871c19cef1b79fc48283be9dd51

…builder API 4/5) Fourth PR of the Gloas builder API stack (beacon-APIs sigp#630): - convert `/eth/v4/validator/blocks/{slot}` to POST with an optional `BuilderConfig` body (min_bid, builder_boost_factor, direct builders) - add `POST /eth/v1/validator/builder_preferences` for forwarding signed builder preferences - set `Eth-Builder-Url` on produceBlockV4 responses when a direct-builder bid wins, accept it on `POST /eth/v2/beacon/blocks`, and forward the signed block to that builder The validator client still uses the legacy GET methods at this point; it migrates in the final PR of this stack. Change-Id: I0ad30b8f36ad9b588ea1a0398220f92c9597bb95

…API 5/5) Final PR of the Gloas builder API stack: - sign builder request-auth and preferences (REQUEST_AUTH signing domain, web3signer message type) - add the builder configuration store (`builder_definitions.yml`) and book documentation - add the builder-preferences service and switch block production to `POST` produceBlockV4 with a `BuilderConfig` body, threading the `Eth-Builder-Url` header through block publication - remove the now-unused legacy `GET` produceBlockV4 client methods Change-Id: Iaeeaf6205a024e4fb9fd11aae6ac6a75978a8320

…builder API 4/5) Fourth PR of the Gloas builder API stack (beacon-APIs sigp#630): - convert `/eth/v4/validator/blocks/{slot}` to POST with an optional `BuilderConfig` body (min_bid, builder_boost_factor, direct builders) - add `POST /eth/v1/validator/builder_preferences` for forwarding signed builder preferences - set `Eth-Builder-Url` on produceBlockV4 responses when a direct-builder bid wins, accept it on `POST /eth/v2/beacon/blocks`, and forward the signed block to that builder The validator client still uses the legacy GET methods at this point; it migrates in the final PR of this stack. Change-Id: I0ad30b8f36ad9b588ea1a0398220f92c9597bb95

…API 5/5) Final PR of the Gloas builder API stack: - sign builder request-auth and preferences (REQUEST_AUTH signing domain, web3signer message type) - add the builder configuration store (`builder_definitions.yml`) and book documentation - add the builder-preferences service and switch block production to `POST` produceBlockV4 with a `BuilderConfig` body, threading the `Eth-Builder-Url` header through block publication - remove the now-unused legacy `GET` produceBlockV4 client methods Change-Id: Iaeeaf6205a024e4fb9fd11aae6ac6a75978a8320

mergify · 2026-09-09T15:44:03Z

This pull request has merge conflicts. Could you please resolve them @jimmygchen? 🙏

ethDreamer and others added 4 commits August 26, 2026 14:12

Skip envelope fetch for external builder blocks

9121df2

Changes: Skip validator payload-envelope handling after external-builder block publication. Cover self-build and external-builder envelope behaviour.

jimmygchen added the gloas label Aug 31, 2026

jimmygchen added 2 commits August 31, 2026 05:28

Clarify payload envelope handling

cce904b

Reject non-Gloas block responses

dc6e301

jimmygchen marked this pull request as ready for review August 31, 2026 07:15

jimmygchen added the ready-for-review The code is ready for review label Aug 31, 2026

jimmygchen requested a review from ethDreamer September 1, 2026 02:52

ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 44f4424 to 17bcbc2 Compare September 1, 2026 17:18

ethDreamer requested a review from jxs as a code owner September 1, 2026 17:18

mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 1, 2026

ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 17bcbc2 to 7c1ffce Compare September 1, 2026 18:32

shane-moore reviewed Sep 2, 2026

View reviewed changes

This was referenced Sep 2, 2026

Envelope duty trigger keyed on the local block in Lighthouse block service sigp/anchor#1287

Open

feat: replace envelope QBFT with disseminate-and-sign (SIP-94 §6) sigp/anchor#1286

Merged

ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 7c1ffce to 58eedb5 Compare September 2, 2026 15:53

shane-moore mentioned this pull request Sep 2, 2026

feat(validator_store): detach non-builder envelope signing from the Lighthouse callback shane-moore/anchor#1

Merged

ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch 2 times, most recently from 2c3656e to 39cf3c2 Compare September 3, 2026 21:03

ethDreamer added 3 commits September 3, 2026 17:20

ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 39cf3c2 to 9abe9a1 Compare September 3, 2026 22:40

Resolve conflicts with updated builder API base

82af379

ovidiu-ssv-labs mentioned this pull request Sep 7, 2026

The execution payload envelope duty stops after BLOCK_ERROR_ALREADY_KNOWN, and it asks for the wrong block root sigp/anchor#1293

Closed

ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 9abe9a1 to 58fba0d Compare September 8, 2026 17:21

ethDreamer added 2 commits September 8, 2026 16:28

ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 58fba0d to 2a6fc09 Compare September 8, 2026 22:42

Resolve conflicts with updated builder API base

c6d9662

jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 9, 2026

ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 2a6fc09 to a434c7d Compare September 9, 2026 14:33

mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 9, 2026

Navigation Menu

Uh oh!

Stop external-builder envelope 404 after block publication - #9948

Stop external-builder envelope 404 after block publication#9948
jimmygchen wants to merge 13 commits into
sigp:stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620from
jimmygchen:fix-external-builder-envelope-404

jimmygchen commented Aug 31, 2026

Uh oh!

mergify Bot commented Sep 1, 2026

Uh oh!

shane-moore Sep 2, 2026 •

edited

Loading

Uh oh!

mergify Bot commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		publish_envelope =
		signed_execution_payload_bid.message.builder_index == BUILDER_INDEX_SELF_BUILD;

Uh oh!

Conversation

jimmygchen commented Aug 31, 2026

Uh oh!

mergify Bot commented Sep 1, 2026

Uh oh!

shane-moore Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shane-moore Sep 2, 2026 •

edited

Loading